Skip to content

update M5Camera pins #4021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 22, 2020
Merged

update M5Camera pins #4021

merged 4 commits into from
May 22, 2020

Conversation

Gitshaoxiang
Copy link
Contributor

update the pins number:
product docs:
https://docs.m5stack.com/#/en/unit/m5camera

@me-no-dev
Copy link
Member

what happens with the old pins? my current camera?

@Gitshaoxiang
Copy link
Contributor Author

actually we just produce few "old pins" version camera before. it already stop produce more than one year. we must user are use the "new pins" version

@me-no-dev
Copy link
Member

maybe we should add it as V2 instead. You will be breaking cameras this way, regradles when they are made. As you see, I added support for all your cameras.

@@ -11,6 +11,7 @@
#define CAMERA_MODEL_WROVER_KIT // Has PSRAM
//#define CAMERA_MODEL_ESP_EYE // Has PSRAM
//#define CAMERA_MODEL_M5STACK_PSRAM // Has PSRAM
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to add better explanation to both boards, so it is easier for users to distinguish. Like "manufactured before ..." or something else.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it is enough. i add the "version B" note. our user will know it. actually , we just saled few old version. most is version B. that is why i hope change it not add a new version. but add a version B define is a good solution. could you meger the PR.?

@me-no-dev me-no-dev merged commit 79f77af into espressif:master May 22, 2020
@me-no-dev
Copy link
Member

done :)

vvhh2002 pushed a commit to vvhh2002/arduino-esp32 that referenced this pull request Jun 15, 2020
* master:
  M5Stack's product offering includes various ESP32-based camera devices. (espressif#4030)
  Fix for issue 3974 m_connectedCount incorrectly decremented when no connection exists
  Add a new board of KITS for IoT education (espressif#3703)
  update M5Camera pins (espressif#4021)
  Update SD_MMC.cpp (espressif#4020)
  Added missing wifi_provisioning dependency. (espressif#4003)
  HardwareSerial bugfix & improvement (espressif#3713)
  Allow using custom linker scripts (espressif#3735)
  Add M5Stack-ATOM Board (espressif#3883)
  Minor modifications in provisioning (espressif#3919)
  Add support of unified provisioning to Arduino
  Update install-platformio-esp32.sh
  add new board Handbit  (espressif#3807)
  Move _STREAM_BOUNDARY before _STREAM_PART (espressif#3720)
  Add Senses's WEIZEN board from Senses IoT platform (espressif#3687)
  Revert "std::shared_ptr Memory Leak (espressif#3680)" (espressif#3682)
  std::shared_ptr Memory Leak (espressif#3680)
  Minimize HardwareSerial Receive and Transmit delays (espressif#3664)
  fix removeApbChangeCallback() error in spiStopBus() (espressif#3675)

# Conflicts:
#	CMakeLists.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants